Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getColor is deprecated #32

Open
Rushi98 opened this issue Jun 2, 2018 · 3 comments
Open

getColor is deprecated #32

Rushi98 opened this issue Jun 2, 2018 · 3 comments
Assignees
@mohanish3
Labels
bug Something isn't working

Comments

@Rushi98
Copy link
Member

Rushi98 commented Jun 2, 2018

Introduced by @mohanish3 via #26 in aboutmac/AboutMacActivity.

See https://developer.android.com/reference/android/content/res/Resources#getColor(int) for reference
@Rushi98 Rushi98 added the bug Something isn't working label Jun 2, 2018
@mohanish3
Copy link
Collaborator

It's deprecated for API level 23 and above, but our min API level is 21 which does not have the new method.

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 22, 2018

can be but in if (BuildConfig.Version) block

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 22, 2018

using the newer api will enable us to support theming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanish3 mohanish3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohanish3 @Rushi98