Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ignore and custom error message flags. #38

Open
JoshLind opened this issue May 10, 2022 · 3 comments
Open

[Feature Request] Ignore and custom error message flags. #38

JoshLind opened this issue May 10, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@JoshLind
Copy link

Hi! Thanks for building this awesome tool! 😄 We're currently working on integrating it into our project at Aptos Labs.

A couple feature requests that might be useful:

  1. --ignore flag to explicitly exclude certain directories or files from verification. We currently use the --workspace flag, but some of our cargo files are automatically generated (without ordering). It would be great to tell the tool to ignore these.
  2. --custom-error-message flag to display a custom error message when the --check command fails. Instead of just displaying error: Dependencies for <crate> are not sorted. It would be nice to display a custom message, e.g., Dependencies for <crate> are not sorted. To sort them, run <command>. For more information, visit: <cargo-sort url>.
@JoshLind JoshLind changed the title [Feature Request] [Feature Request] Ignore and custom error message flags. May 10, 2022
@DevinR528
Copy link
Owner

Thanks! Sorry for the slow response. Both of these are great ideas! I have had feedback that the error message isn't very good (which I agree with) what do you think of just changing the error message to that, I know all the info is there (the crate)? The ignore flag is a great idea! Are you interested in making a PR I'm happy to help/review, if not I have a few things backed up at the moment but since this is a smaller more doable issue I can probably get to it in the next few days.

@JoshLind
Copy link
Author

Thanks @DevinR528! Apologies for the delay in responding:

  1. I'd prefer the ability for a custom error message, but a more descriptive default also makes sense 😄
  2. No rush on the improvements (I won't be able to get to it soon, either!). Just wanted to make you aware of these asks.

Thanks again!

@DevinR528
Copy link
Owner

No worries, and yeah, they would both be awesome additions!!

@DevinR528 DevinR528 added the enhancement New feature or request label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants