Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors when loading config should always exit with code 3 #57

Closed
DetachHead opened this issue Jan 25, 2024 · 3 comments · Fixed by #62
Closed

errors when loading config should always exit with code 3 #57

DetachHead opened this issue Jan 25, 2024 · 3 comments · Fixed by #62
Labels
p1

Comments

@DetachHead
Copy link
Owner

related: #38
@DetachHead DetachHead added the p1 label Jan 26, 2024
@DetachHead DetachHead changed the title errors when loading config should stop the execution and exit with a non-zero exit code errors when loading config should stop the execution Jan 26, 2024
@DetachHead
Copy link
Owner Author

actually they already exit with code 3, but it doesn't stop execution

@DetachHead DetachHead added p1 and removed p1 labels Jan 26, 2024
@DetachHead DetachHead changed the title errors when loading config should stop the execution errors when loading config should stop the execution and always exit with code 4 Jan 26, 2024
@DetachHead DetachHead changed the title errors when loading config should stop the execution and always exit with code 4 errors when loading config should stop the execution and always exit with code 3 Jan 26, 2024
@DetachHead
Copy link
Owner Author

AACSHUALLY not all errors do that, eg:

> basedpyright
Config "include" entry must must contain an array.
0 errors, 0 warnings, 0 informations
> echo $LASTEXITCODE
0

@DetachHead DetachHead mentioned this issue Jan 26, 2024
Merged
@DetachHead DetachHead changed the title errors when loading config should stop the execution and always exit with code 3 errors when loading config should always exit with code 3 Jan 26, 2024
@DetachHead DetachHead mentioned this issue Jan 26, 2024
Open
@DetachHead
Copy link
Owner Author

split this into 2 separate issues (#63) since this one seems harder to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1
Projects
None yet
Milestone
No milestone
1 participant
@DetachHead