Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reportUnusedParameter rule #336

Closed
DetachHead opened this issue May 5, 2024 · 3 comments · Fixed by #589
Closed

add reportUnusedParameter rule #336

DetachHead opened this issue May 5, 2024 · 3 comments · Fixed by #589
Labels
language server type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules

Comments

@DetachHead
Copy link
Owner 

def foo(asdf: int): # no error when asdf is unused
    pass

this was probably caused by #326
@DetachHead DetachHead added language server type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules labels May 5, 2024
@DetachHead
Copy link
Owner Author

looks like this is because reportUnusedVariable doesn't report error/warning/info diagnostic levels on function parameters, but it always reported the "unused" diagnostic. i think for backwards compatibility we should fix this by making a separate reportUnusedParameter rule

@DetachHead DetachHead changed the title reportUnusedVariable no longer works add reportUnusedParameter rule May 6, 2024
@vikigenius
Copy link

What's the status on this? Currently I have no way of specifying how to handle unused function parameters.

@DetachHead
Copy link
Owner Author

can you add a 👍 react on this issue to vote for it. helps us prioritise based on demand. thanks!

This was referenced Aug 17, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language server type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add reportUnusedParameter rule DetachHead/basedpyright
2 participants
@vikigenius @DetachHead