Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream version output only works when installing from source #251

Closed
DetachHead opened this issue Apr 3, 2024 · 2 comments · Fixed by #256
Closed

upstream version output only works when installing from source #251

DetachHead opened this issue Apr 3, 2024 · 2 comments · Fixed by #256

Comments

@DetachHead
Copy link
Owner

original comment by @AThePeanut4: #218 (comment)

This only seems to work when building from source, the release packages print the incorrect upstream version:

> basedpyright --version
basedpyright 1.8.0
based on pyright 1.8.0

This happens when installing with pip install basedpyright, and with npm install -g basedpyright (the latter installs as pyright, so the command there is pyright --version).

@DetachHead
Copy link
Owner Author

DetachHead commented Apr 4, 2024

actually i think i unintentionally already fixed this in #249, so it should work in the next release.

the issue was that the version number was being changed before the npm package was being built, which is no longer the case

@DetachHead
Copy link
Owner Author

nvm this is still broken :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant