Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display NVD API Attribution Notice #3294

Closed
2 tasks done
jgraglia opened this issue Dec 12, 2023 · 4 comments · Fixed by #3490
Closed
2 tasks done

Display NVD API Attribution Notice #3294

jgraglia opened this issue Dec 12, 2023 · 4 comments · Fixed by #3490
Labels
defect Something isn't working good first issue Good for newcomers p3 Nice-to-have features
Milestone

Comments

@jgraglia
Copy link

Current Behavior

Since Dependency Track use NVD Rest API (with the APIKEY provided by the deployer) the product Dependency Track should have to respect the Terms of Use of the NVD API and display somewhere the required notice

This product uses the NVD API but is not endorsed or certified by the NVD.

OWASP Dependency Check had the same issue : jeremylong/DependencyCheck#6105

Steps to Reproduce

Browse the available documentation on the website: no notice
google search prompt : site:https://docs.dependencytrack.org/ "This product uses the NVD API but is not"

No notice on the about dialog in v 4.10.0 the NVD appears in the DATASOURCE PROVIDERS but without the notice.
image

Expected Behavior

The NVD terms of use should be respected.

Dependency-Track Version

4.7.x

Dependency-Track Distribution

Container Image

Database Server

PostgreSQL

Database Server Version

15

Browser

Google Chrome

Checklist

@jgraglia jgraglia added defect Something isn't working in triage labels Dec 12, 2023
@jgraglia
Copy link
Author

Oops... by bad. it is displayed exactly as required in the NVD configuration page admin/vulnerabilitySources/nvd Sorry !

@jgraglia
Copy link
Author

I did have checked this repo for the line... but it is defined in another repo, the frontend one
https://github.com/DependencyTrack/frontend/blob/cf09e79bd76dea39526b550a9f86ab6089947482/src/i18n/locales/en.json#L639

@msymons
Copy link
Member

msymons commented Dec 13, 2023

@jgraglia, I am re-opening this issue as we do need to do a better job here. The Terms of Use specify that the notice must be displayed prominently... and showing it on a configuration page that can only be seen by administrators is not what anyone would think of as being "prominent".

Within the application, the "About" dialog is probably the best place to display the notice. If need be, perhaps the dialog could be tabbed so that screen real-estate is not a problem.

The Documentation website should also be updated.

@msymons msymons reopened this Dec 13, 2023
@msymons msymons added p3 Nice-to-have features and removed in triage labels Dec 13, 2023
@msymons msymons added this to the 4.11 milestone Jan 4, 2024
@nscuro nscuro added the good first issue Good for newcomers label Feb 22, 2024
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working good first issue Good for newcomers p3 Nice-to-have features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants