Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive reported vulnerability #2259

Open
2 tasks done
manuel-sommer opened this issue Dec 9, 2022 · 4 comments
Open
2 tasks done

False positive reported vulnerability #2259

manuel-sommer opened this issue Dec 9, 2022 · 4 comments
Labels
defect Something isn't working FP/FN report False Positive or False Negative in triage

Comments

@manuel-sommer
Copy link
Contributor

Current Behavior

DependencyTrack reports a false positive CVE as the version from NVD is not compared in the right way. If you upload the following cyclonedx file to DependencyTrack 4.5.0, DependencyTrack will report a vulnerability which was fixed in 4.0.6. However, the version in the cyclonedx file is 4.1.3.

See screenshot and cyclonedx file.
Screenshot from 2022-12-07 13-31-46
cyclonedx.zip

Steps to Reproduce

  1. Upload the attached cyclonedx file to DependencyTrack 4.5.0.
  2. See if the CVE-34265 is reported in DependencyTrack.

Expected Behavior

CVE-34265 is not reported in DependencyTrack.

Dependency-Track Version

4.5.x

Dependency-Track Distribution

Container Image

Database Server

N/A

Database Server Version

No response

Browser

Google Chrome

Checklist

@manuel-sommer manuel-sommer added defect Something isn't working in triage labels Dec 9, 2022
@nscuro nscuro added the FP/FN report False Positive or False Negative label Dec 11, 2022
@nscuro
Copy link
Member

nscuro commented Dec 11, 2022

Hey @manuel-sommer, thanks for reporting!

What does the Analyzer column of the table in your screenshot say? If it says OSS Index, then it was reported an external source and DT can't do anything about it. It seems like OSS Index previously reported CVE-2022-34264 (OSSIndex/vulns#332), but it doesn't anymore.

@manuel-sommer
Copy link
Contributor Author

Hey @nscuro , yeah it says "OSS Index".
What is the workflow in DependencyTrack to deal with this?

@valentijnscholten
Copy link
Contributor

valentijnscholten commented Dec 13, 2022

In 4.7.0 there will be a "Reanalyze" button in the project view which could be used to reanalyze. If OSSIndex no longer reports the vulnerability it should disappear, although I am not sure if DT actually removes vulnerabilities that are no longer reported or only adds new ones when applicable.

A quick look at the code seems to indicate no longer attributed vulnerabilities are not (yet) removed.

@nscuro
Copy link
Member

nscuro commented Dec 13, 2022

A quick look at the code seems to indicate no longer attributed vulnerabilities are not (yet) removed.

Correct. Instead of removing those vulns, automatically suppressing them and / or labeling them as RESOLVED would be better.

The limitation is currently that multiple sources may report such a vulnerability, but only the first of them to report it is captured in the FindingAttribution. If we wanted an automatism that auto-resolves vulns, we need to track all analyzers that reported it, not just the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working FP/FN report False Positive or False Negative in triage
Projects
None yet
Development

No branches or pull requests

3 participants