Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake data is included with browserify bundle #1

Open
ryanramage opened this issue Jan 9, 2015 · 0 comments
Open

fake data is included with browserify bundle #1

ryanramage opened this issue Jan 9, 2015 · 0 comments

Comments

@ryanramage
Copy link

Over the last couple days I have been working on isomorphic react, and then I stumbled on your example. One issue I see is that the fake data file is bundled with the browserify build and shipped with the js the browser loads. Most apps will retrieve the data at runtime from a store or api and wont be able to do this.

It would be nice if isomorphic-react-example could show loading data from some public api and rendering that serverside and then having the client mount that component.

So far the only way I have found to deal with this is to JSON.stringify the data on the server included in the html, and then on the client JSON.parse the data and pass it to the ReactApp component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant