Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] private field for the HTTPipe.Conn.t #10

Open
stephenmoloney opened this issue Feb 23, 2017 · 2 comments
Open

[Proposal] private field for the HTTPipe.Conn.t #10

stephenmoloney opened this issue Feb 23, 2017 · 2 comments

Comments

@stephenmoloney
Copy link

  • In order to add custom elements in a library which uses HTTPipe, I think the field private would be desirable.
  • At the moment I'm just adding my custom fields to the HTTPipe.Conn.t which is not ideal.
    Plug has a private field.

https://github.com/elixir-lang/plug/blob/v1.3.0/lib/plug/conn.ex#L163

@DavidAntaramian, your thoughts on this?

@DavidAntaramian
Copy link
Owner

That would probably be a good idea. Though perhaps private is a bad choice since it implies it's reserved for HTTPipe's use? I am thinking something like custom_fields and recommending that users namespace it to their application.

@stephenmoloney
Copy link
Author

Yea, custom_fields sounds good and +1 for recommending namespacing with it (to avoid potential conflicts).

If you need me to contribute, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants