From de4b4eb20197fed8bc43dfee37d791df3c94dd88 Mon Sep 17 00:00:00 2001
From: Fanny Jiang <fanny.jiang@datadoghq.com>
Date: Thu, 26 May 2022 12:46:39 -0400
Subject: [PATCH] add connectivity metrics

---
 arangodb/datadog_checks/arangodb/metrics.py | 8 ++++++++
 arangodb/metadata.csv                       | 9 +++++++++
 arangodb/tests/common.py                    | 9 +++++++++
 3 files changed, 26 insertions(+)

diff --git a/arangodb/datadog_checks/arangodb/metrics.py b/arangodb/datadog_checks/arangodb/metrics.py
index 3cd67d19d8ef1..76e685554e7b4 100644
--- a/arangodb/datadog_checks/arangodb/metrics.py
+++ b/arangodb/datadog_checks/arangodb/metrics.py
@@ -120,5 +120,13 @@
         'arangodb_dropped_followers': {'name': 'health.dropped_followers'},
         'arangodb_heartbeat_failures': {'name': 'health.heartbeat_failures'},
         'arangodb_heartbeat_send_time_msec': {'name': 'health.heartbeat.sent.time'},
+        # connectivity
+        'arangodb_connection_pool_connections_created': {'name': 'connection_pool.connections.created'},
+        'arangodb_connection_pool_connections_current': {'name': 'connection_pool.connections.current'},
+        'arangodb_connection_pool_lease_time_hist': {'name': 'connection_pool.lease_time'},
+        'arangodb_connection_pool_leases_failed': {'name': 'connection_pool.leases.failed'},
+        'arangodb_connection_pool_leases_successful': {'name': 'connection_pool.leases.successful'},
+        'arangodb_http2_connections': {'name': 'http2.connections'},
+        'arangodb_vst_connections': {'name': 'vst.connections'},
     }
 ]
diff --git a/arangodb/metadata.csv b/arangodb/metadata.csv
index e5d0e1f04009e..bf55d0caed30d 100644
--- a/arangodb/metadata.csv
+++ b/arangodb/metadata.csv
@@ -137,3 +137,12 @@ arangodb.health.heartbeat_failures.count,count,,,,Total number of failed heartbe
 arangodb.health.heartbeat.sent.time.bucket,count,,millisecond,,Count of times required to send heartbeats.,0,arangodb,health heartbeat sent time bucket,
 arangodb.health.heartbeat.sent.time.count,count,,millisecond,,Count of times required to send heartbeats.,0,arangodb,health heartbeat sent time count,
 arangodb.health.heartbeat.sent.time.sum,count,,millisecond,,Count of times required to send heartbeats.,0,arangodb,health heartbeat sent time sum,
+arangodb.connection_pool.connections.created.count,count,,,,Total number of connections created for connection pool.,0,arangodb,connection pool connections created count,
+arangodb.connection_pool.connections.current,gauge,,,,Current number of connections in pool.,0,arangodb,connection pool connections current,
+arangodb.connection_pool.lease_time.bucket,count,,millisecond,,Count of time to lease a connection from the connection pool.,0,arangodb,connection pool lease time bucket,
+arangodb.connection_pool.lease_time.count,count,,millisecond,,Count of time to lease a connection from the connection pool.,0,arangodb,connection pool lease time count,
+arangodb.connection_pool.lease_time.sum,count,,millisecond,,Count of time to lease a connection from the connection pool.,0,arangodb,connection pool lease time sum,
+arangodb.connection_pool.leases.failed.count,count,,,,Total number of failed connection leases.,0,arangodb,connection pool leases failed count,
+arangodb.connection_pool.leases.successful.count,count,,,,Total number of successful connection leases from connection pool.,0,arangodb,connection pool leases successful count,
+arangodb.http2.connections.count,count,,,,Total number of connections accepted for HTTP/2.,0,arangodb,http2 connections count,
+arangodb.vst.connections.count,count,,,,Total number of connections accepted for VST.,0,arangodb,vst connections count,
\ No newline at end of file
diff --git a/arangodb/tests/common.py b/arangodb/tests/common.py
index b516df920d356..9eede2e22e3e2 100644
--- a/arangodb/tests/common.py
+++ b/arangodb/tests/common.py
@@ -128,6 +128,15 @@
     'arangodb.health.heartbeat.sent.time.bucket',
     'arangodb.health.heartbeat.sent.time.count',
     'arangodb.health.heartbeat.sent.time.sum',
+    'arangodb.connection_pool.connections.created.count',
+    'arangodb.connection_pool.connections.current',
+    'arangodb.connection_pool.lease_time.bucket',
+    'arangodb.connection_pool.lease_time.count',
+    'arangodb.connection_pool.lease_time.sum',
+    'arangodb.connection_pool.leases.failed.count',
+    'arangodb.connection_pool.leases.successful.count',
+    'arangodb.http2.connections.count',
+    'arangodb.vst.connections.count',
 ]
 
 OPTIONAL_METRICS = [