-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidekiq integration broke with Rails 6.0.2 #943
Comments
Ah okay, this makes sense, we'll get a bugfix out for this. Thanks @pj0tr! |
+1 We're also running into the same issue. @delner I'd be happy to help reproduce. I'm not quite sure how to build the gem at this sha and use it in my local environment though. Any guidance there? |
@mattmcf You have two options to use the current PR #947:
source 'http://gems.datadoghq.com/prerelease' do
gem 'ddtrace', '0.32.0.fix.sidekiq.with.rails.6.0.2.56001'
end |
@delner Thanks! That worked great. I can confirm that this fix addressed the issue for me. I'm now seeing spans emitted when I wasn't before. |
Okay, wonderful, thanks for the confirmation @mattmcf! We'll get this merged and released. |
@delner Do you know when you'll cut the release? |
Likely next week. |
rails/rails@0e64348 changed job['wrapped'] to contain a class instead of the class name as a string, causing these types of errors whenever a trace contains a Sidekiq job.
ERROR -- ddtrace: [ddtrace] (/usr/local/bundle/gems/ddtrace-0.32.0/lib/ddtrace/transport/http/client.rb:46:in `rescue in send_request') Internal error during HTTP transport request. Cause: undefined method `to_msgpack' for Searchkick::ReindexV2Job:Class Location: /usr/local/bundle/gems/msgpack-1.3.1/lib/msgpack.rb:46:in `write'
The text was updated successfully, but these errors were encountered: