Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set template/partial name as the resource for rails.render_template and rails.render_partial #855

Closed
djmb opened this issue Nov 15, 2019 · 3 comments · Fixed by #881
Closed

Set template/partial name as the resource for rails.render_template and rails.render_partial #855

djmb opened this issue Nov 15, 2019 · 3 comments · Fixed by #881
Assignees
@delner
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Milestone
0.31.0

Comments

@djmb
Copy link

djmb commented Nov 15, 2019

The action_view integration doesn't set a resource for the rails.render_template and rails.render_partial spans. This means that everything gets lumped together in the span summary.

It would be useful it it used the template or partial name as the resource.
@delner
Copy link
Contributor

delner commented Nov 15, 2019

@djmb Hmmm, I think you're right; I don't see any setting of the resource in our ActionView instrumentation. We probably should change that, thanks for the suggestion!

@delner delner added community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations labels Nov 15, 2019
@delner delner self-assigned this Nov 15, 2019
@marcotc marcotc mentioned this issue Dec 10, 2019
Merged
@delner
Copy link
Contributor

delner commented Dec 17, 2019

Just a heads up @djmb, we addressed this in #881 which was merged to master and should roll with the next release 0.31.0.

Thanks again for the suggestion!

@delner delner added this to the 0.31.0 milestone Dec 17, 2019
@marcotc
Copy link
Member

marcotc commented Jan 7, 2020

Hi @djmb, we've just released this feature in 0.31.0.

Give it a try and let us know if you have any further feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delner delner

Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Add resource for Rails template spans DataDog/dd-trace-rb
3 participants
@marcotc @djmb @delner