Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ruby 2.7 #805

Closed
marcotc opened this issue Sep 3, 2019 · 3 comments · Fixed by #896
Closed

Support for Ruby 2.7 #805

marcotc opened this issue Sep 3, 2019 · 3 comments · Fixed by #896
Assignees
Labels
feature-request A request for a new feature or change to an existing one
Milestone

Comments

@marcotc
Copy link
Member

marcotc commented Sep 3, 2019

With Ruby 2.7 scheduled to be released December 2019, dd-trace-rb should be ready to support it on release date.

There are a few confirmed blockers affecting the latest release, 2.7.0-preview1:

Blockers

  • 2.7.0-preview1 is affected by https://bugs.ruby-lang.org/issues/15891, which prevents dd-trace-rb from starting up successfully. This has been fixed in Ruby master branch, which is still unreleased.

Contrib

  • grpc, as of version 1.23.0, doesn't support Ruby 2.7, failing installation with: grpc requires Ruby version >= 2.3, < 2.7.dev
@marcotc marcotc added the feature-request A request for a new feature or change to an existing one label Sep 3, 2019
@delner
Copy link
Contributor

delner commented Sep 4, 2019

For grpc we could simply restrict the version support to < 2.7 until gRPC is updated.

@marcotc
Copy link
Member Author

marcotc commented Nov 29, 2019

I created a branch to test this, after 2.7.0-preview3 has been released: https://github.com/DataDog/dd-trace-rb/tree/ci/ruby-2.7-preview3

All gems loaded properly, except for grpc and graphql: grpc has the same issue mentioned earlier, and graphql tries to load a file that has been removed in 2.7.

For everything else, tests pass.

I'll follow up again closer to release, but things look promising so far.

@marcotc
Copy link
Member Author

marcotc commented Dec 20, 2019

PR is open in draft mode, #896, awaiting the official release of 2.7 Docker containers.

@marcotc marcotc added this to the 0.31.0 milestone Jan 7, 2020
@marcotc marcotc self-assigned this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature or change to an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants