You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the case of configuring the datadog trace client, when passing a custom logger into the datadog client the custom logger's level will be changed to WARN. This had a negative effect on our system, hiding all INFO logs. Example of our configuration:
This hit us too. I had to monkey patch Rails.logger.level= to print a stack trace in production in order to find the cause of it as I couldn't reproduce it anywhere else.
In the case of configuring the datadog trace client, when passing a custom logger into the datadog client the custom logger's level will be changed to WARN. This had a negative effect on our system, hiding all INFO logs. Example of our configuration:
Once Datadog trace is configured
debug_logging=
will be called here:https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/configuration.rb#L49
Because
debug = false
(a default) the log level for the passed in custom logger will be changed to WARN here:https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/tracer.rb#L57
My suggestion would be to keep the same behavior only if the detected logger configured is a Datadog::Logger otherwise noop. Thoughts?
The text was updated successfully, but these errors were encountered: