|
688 | 688 | end
|
689 | 689 | end
|
690 | 690 |
|
691 |
| - describe '#preview_gvl_enabled' do |
692 |
| - subject(:preview_gvl_enabled) { settings.profiling.advanced.preview_gvl_enabled } |
| 691 | + describe '#preview_gvl_enabled=' do |
| 692 | + it 'logs a warning informing customers this no longer does anything' do |
| 693 | + expect(Datadog.logger).to receive(:warn).with(/no longer does anything/) |
693 | 694 |
|
694 |
| - it_behaves_like 'a binary setting with', env_variable: 'DD_PROFILING_PREVIEW_GVL_ENABLED', default: false |
| 695 | + settings.profiling.advanced.preview_gvl_enabled = true |
| 696 | + end |
695 | 697 | end
|
696 | 698 |
|
697 |
| - describe '#preview_gvl_enabled=' do |
698 |
| - it 'updates the #preview_gvl_enabled setting' do |
699 |
| - expect { settings.profiling.advanced.preview_gvl_enabled = true } |
700 |
| - .to change { settings.profiling.advanced.preview_gvl_enabled } |
701 |
| - .from(false) |
702 |
| - .to(true) |
| 699 | + describe '#gvl_enabled' do |
| 700 | + subject(:gvl_enabled) { settings.profiling.advanced.gvl_enabled } |
| 701 | + |
| 702 | + it_behaves_like 'a binary setting with', env_variable: 'DD_PROFILING_GVL_ENABLED', default: true |
| 703 | + |
| 704 | + context 'when DD_PROFILING_PREVIEW_GVL_ENABLED' do |
| 705 | + around do |example| |
| 706 | + ClimateControl.modify('DD_PROFILING_PREVIEW_GVL_ENABLED' => environment) do |
| 707 | + example.run |
| 708 | + end |
| 709 | + end |
| 710 | + |
| 711 | + context 'is not defined' do |
| 712 | + let(:environment) { nil } |
| 713 | + |
| 714 | + it { is_expected.to be true } |
| 715 | + end |
| 716 | + |
| 717 | + [true, false].each do |value| |
| 718 | + context "is defined as #{value}" do |
| 719 | + let(:environment) { value.to_s } |
| 720 | + |
| 721 | + before { expect(Datadog::Core).to receive(:log_deprecation) } |
| 722 | + |
| 723 | + it { is_expected.to be value } |
| 724 | + end |
| 725 | + end |
| 726 | + end |
| 727 | + end |
| 728 | + |
| 729 | + describe '#gvl_enabled=' do |
| 730 | + it 'updates the #gvl_enabled setting' do |
| 731 | + expect { settings.profiling.advanced.gvl_enabled = false } |
| 732 | + .to change { settings.profiling.advanced.gvl_enabled } |
| 733 | + .from(true) |
| 734 | + .to(false) |
703 | 735 | end
|
704 | 736 | end
|
705 | 737 |
|
|
0 commit comments