Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js plugin #2912

Closed
nhomble opened this issue Mar 20, 2023 · 2 comments
Closed

grpc-js plugin #2912

nhomble opened this issue Mar 20, 2023 · 2 comments
Labels
feature-request

Comments

@nhomble
Copy link

nhomble commented Mar 20, 2023

Support was previously added for grpc in #311

but this package seems deprecated in favor of grpc-js

Could this tracer library support the new grpc library?
@rochdev
Copy link
Member

rochdev commented Mar 24, 2023

Both libraries are currently supported by dd-trace. Is this not working for you? And if that's the case, can you describe what's not working?

@nhomble
Copy link
Author

nhomble commented Mar 29, 2023

Sorry I misunderstood the docs. After adding .use('grpc') we see traces as expected.

@nhomble nhomble closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rochdev @nhomble