Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to add [APM Request Latency] via DistributionWidgetDefinition class widget #580

Closed
Bartket opened this issue Sep 10, 2021 · 3 comments

Comments

@Bartket
Copy link

Bartket commented Sep 10, 2021

Describe the bug
No possibility to add apm_stats_query to the DistributionWidgetDefinition widget class.
apm_query=LogQueryDefinition does not make it possible to reproduce APM Request Latency distribution chart for the service.

Label the issue properly.
severity/medium

To Reproduce
Steps to reproduce the behavior:

  1. Add DistributionWidgetDefinition widget to the Dashboard class as follows:
            Widget(
                definition=DistributionWidgetDefinition(
                    title="Latency distribution",
                    title_size="16",
                    show_legend=False,
                    title_align=WidgetTextAlign("left"),
                    type=DistributionWidgetDefinitionType("distribution"),
                    xaxis=DistributionWidgetXAxis(max="p95"),
                    yaxis=DistributionWidgetYAxis(scale="linear"),
                    requests=[
                        DistributionWidgetRequest(
                            apm_stats_query=ApmStatsQueryDefinition(
                                env="env",
                                name="service_request",
                                primary_tag="",
                                row_type=ApmStatsQueryRowType("service"),
                                service="service",
                            ),
                        ),
                    ],
                ),
            ),

Expected behavior
Possibility to add apm_stats_query parameter and ApmStatsQueryDefinition class to the DistributionWidgetDefinition class is added.

Screenshots
obraz
I Would like to have this option via Python API for the distribution widget which is not possible now.

Environment and Versions (please complete the following information):
OS: Ubuntu 20.04 LTS
Python: 3.8.10
datadog-api-client: 1.3.0

Additional context
Add any other context about the problem here.

@Bartket Bartket changed the title Not possible to [APM Request Latency] via DistributionWidgetDefinition class widget Not possible to add [APM Request Latency] via DistributionWidgetDefinition class widget Sep 11, 2021
@github-actions
Copy link

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

@github-actions github-actions bot added the stale label Oct 12, 2021
@therve
Copy link
Contributor

therve commented Nov 9, 2021

Hi, I believe it has been fixed with #628 . Thanks.

@therve therve closed this as completed Nov 9, 2021
@Bartket
Copy link
Author

Bartket commented Nov 9, 2021

@therve Cool, I managed to test and push to my repo, works as desired. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants