Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] FuzzHandleTraces* tests are very flaky #13934

Closed
ajgajg1134 opened this issue Oct 18, 2022 · 2 comments · Fixed by #13971
Closed

[Flaky Test] FuzzHandleTraces* tests are very flaky #13934

ajgajg1134 opened this issue Oct 18, 2022 · 2 comments · Fixed by #13971
Assignees
@ajgajg1134
Labels
team/agent-apm trace-agent

Comments

@ajgajg1134
Copy link
Contributor

ajgajg1134 commented Oct 18, 2022 •
edited
Loading

It seems this is due to the timing package spinning up a goroutine on init that accesses the metrics client. Many tests will overwrite the metrics client with a test version (thus creating a data race and failing the test)
@ajgajg1134 ajgajg1134 added the team/agent-apm trace-agent label Oct 18, 2022
@ajgajg1134 ajgajg1134 self-assigned this Oct 18, 2022
@ajgajg1134 ajgajg1134 mentioned this issue Oct 20, 2022
Merged
10 tasks
@gbbr
Copy link
Contributor

gbbr commented Oct 21, 2022

Which init? Do you mean this ?

@ajgajg1134
Copy link
Contributor Author

Yep! That line exactly.

@crobert-1 crobert-1 mentioned this issue Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajgajg1134 ajgajg1134

Labels
team/agent-apm trace-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/trace: Fix flaky tests due to metrics race with Timing package DataDog/datadog-agent
2 participants
@ajgajg1134 @gbbr