Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stalling playback on multi-period MPD #4044

Closed
4 tasks done
camelon opened this issue Sep 16, 2022 · 2 comments · Fixed by #4051
Closed
4 tasks done

Stalling playback on multi-period MPD #4044

camelon opened this issue Sep 16, 2022 · 2 comments · Fixed by #4051
Labels

Comments

@camelon
Copy link

camelon commented Sep 16, 2022

Environment

dashjs config:

streaming: {
  buffer: {
    fastSwitchEnabled: false,
    stableBufferTime: 20,
  },
  gaps: {
    enableSeekFix: true,
  }
}
Steps to reproduce
  1. Play the MPD
Observed behavior

Playback is stalled at the end of 4th period (id: '1/1'). Previous period (id: '0') contains text tracks. When tracking the problem, I found that while playing the period '0', GapController._shouldCheckForGaps() returns false because _onBufferReplacementStarted on text track. Thus, it dries out the buffer by preventing a small gap jump from period '1/1' to '1/2'.

Repro rate: 100% in my app, 20% on a reference DASH-IF JS player.

Console output

Full log
My print-debug logs of GapController can be grepped by CML: string.

@dsilhavy
Copy link
Collaborator

@camelon Can you please check if #4051 would solve this issue for you.

@camelon
Copy link
Author

camelon commented Sep 21, 2022

@dsilhavy It works, no stalling occurred. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants