From 7d22d40516feed73c571809270fea49f0ab1d779 Mon Sep 17 00:00:00 2001 From: Daniel Silhavy Date: Tue, 4 Mar 2025 15:47:47 -0700 Subject: [PATCH] Add unit tests --- src/dash/models/DashManifestModel.js | 3 +++ test/unit/test/dash/dash.models.DashManifestModel.js | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/dash/models/DashManifestModel.js b/src/dash/models/DashManifestModel.js index b2b34ba1e3..ad623eca12 100644 --- a/src/dash/models/DashManifestModel.js +++ b/src/dash/models/DashManifestModel.js @@ -542,6 +542,9 @@ function DashManifestModel() { return null } const frameRate = realRepresentation[DashConstants.FRAMERATE]; + if (!frameRate) { + return null + } if (typeof frameRate === 'string' && frameRate.includes('/')) { const [numerator, denominator] = frameRate.split('/').map(value => parseInt(value, 10)); diff --git a/test/unit/test/dash/dash.models.DashManifestModel.js b/test/unit/test/dash/dash.models.DashManifestModel.js index fbff5cdf03..daaf5be84e 100644 --- a/test/unit/test/dash/dash.models.DashManifestModel.js +++ b/test/unit/test/dash/dash.models.DashManifestModel.js @@ -1665,11 +1665,16 @@ describe('DashManifestModel', function () { describe('getFramerate()', () => { - it('Should be undefined when no Representation is provided', () => { + it('Should be null when no Representation is provided', () => { const framerate = dashManifestModel.getFramerate(); expect(framerate).to.be.null; }) + it('Should be null when not defined', () => { + const framerate = dashManifestModel.getFramerate({}); + expect(framerate).to.be.null; + }) + it('Should parse single integer', () => { const framerate = dashManifestModel.getFramerate({frameRate: '24'}); expect(framerate).to.be.equal(24);