Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of data insights as per figma #1274

Closed
nairabhishek73 opened this issue Oct 16, 2024 · 3 comments · Fixed by #1277
Closed

Alignment of data insights as per figma #1274

nairabhishek73 opened this issue Oct 16, 2024 · 3 comments · Fixed by #1277
Assignees

Comments

@nairabhishek73
Copy link

Match alignment on data insights as per the figma: https://www.figma.com/proto/qLRsjTZGNmoM1h1sy8alux/Dalgo-Designs?page-id=8474%3A34&node-id=8474-530&node-type=frame&viewport=1110%2C372%2C0.27&t=XKANc6MJX7hn0V7d-1&scaling=min-zoom&content-scaling=fixed

Noptice the margins

@himanshudube97 himanshudube97 self-assigned this Oct 16, 2024
@himanshudube97 himanshudube97 linked a pull request Oct 16, 2024 that will close this issue
@himanshudube97
Copy link
Contributor

@nairabhishek73 The margins are now aligned with the figma designs. Since the same UI component (Preview Pane and Data Statistics) is used both in the UI4T and in the side menu, the margins will be reflected in both places

@nairabhishek73
Copy link
Author

Screenshot 2024-10-17 at 4 58 08 PM

Its still not aligned.

Also we should have the dalgo bar at the top, its there in Ui4T but not in the explore tab.

@himanshudube97
Copy link
Contributor

@Ishankoradia
As Nair pointed out, the alignment was off, and there wasno Dalgo bar at the topin the explore tab but was in the ui4t. Both fixed.

@fatchat fatchat closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants