From f4d9db8d65691f4cabd1c9b5b270eddf95641a0f Mon Sep 17 00:00:00 2001 From: Ishankoradia Date: Tue, 24 Dec 2024 12:16:28 +0530 Subject: [PATCH] bug fix; api spec for fetching catalog has changed --- .../Connections/SchemaChangeDetailsForm.tsx | 37 +++++++------ .../SchemaChangeDetailsForm.test.tsx | 52 ++++++++++--------- 2 files changed, 48 insertions(+), 41 deletions(-) diff --git a/src/components/Connections/SchemaChangeDetailsForm.tsx b/src/components/Connections/SchemaChangeDetailsForm.tsx index 6f63225d..63c10f79 100644 --- a/src/components/Connections/SchemaChangeDetailsForm.tsx +++ b/src/components/Connections/SchemaChangeDetailsForm.tsx @@ -120,24 +120,27 @@ const SchemaChangeDetailsForm = ({ } else if (transform.transformType === 'add_stream') { changedColumns.push(`+Stream: ${tableName}`); } else { - changedColumns = transform.updateStream.reduce((columns: string[], update: any) => { - if ( - update.transformType === 'add_field' || - update.transformType === 'remove_field' || - update.transformType === 'update_field_schema' - ) { - if (update.transformType === 'update_field_schema') { - columns.push(`+${update.fieldName.join(', ')}`); - } else { - columns.push( - `${ - update.transformType === 'add_field' ? '+' : '-' - }${update.fieldName.join(', ')}` - ); + changedColumns = transform.updateStream.fieldTransforms.reduce( + (columns: string[], update: any) => { + if ( + update.transformType === 'add_field' || + update.transformType === 'remove_field' || + update.transformType === 'update_field_schema' + ) { + if (update.transformType === 'update_field_schema') { + columns.push(`+${update.fieldName.join(', ')}`); + } else { + columns.push( + `${ + update.transformType === 'add_field' ? '+' : '-' + }${update.fieldName.join(', ')}` + ); + } } - } - return columns; - }, []); + return columns; + }, + [] + ); } return { name: tableName, changedColumns }; diff --git a/src/components/Connections/__tests__/SchemaChangeDetailsForm.test.tsx b/src/components/Connections/__tests__/SchemaChangeDetailsForm.test.tsx index 63d7b760..a7677214 100644 --- a/src/components/Connections/__tests__/SchemaChangeDetailsForm.test.tsx +++ b/src/components/Connections/__tests__/SchemaChangeDetailsForm.test.tsx @@ -78,18 +78,20 @@ const nonBreakingData = { streamDescriptor: { name: 'worldometer_data', }, - updateStream: [ - { - transformType: 'add_field', - fieldName: ['Second new column'], - breaking: false, - }, - { - transformType: 'add_field', - fieldName: ['New column of nulls'], - breaking: false, - }, - ], + updateStream: { + fieldTransforms: [ + { + transformType: 'add_field', + fieldName: ['Second new column'], + breaking: false, + }, + { + transformType: 'add_field', + fieldName: ['New column of nulls'], + breaking: false, + }, + ], + }, }, ], }, @@ -347,18 +349,20 @@ describe('SchemaChangeDetailsForm', () => { streamDescriptor: { name: 'worldometer_data', }, - updateStream: [ - { - transformType: 'add_field', - fieldName: ['Second new column'], - breaking: false, - }, - { - transformType: 'add_field', - fieldName: ['New column of nulls'], - breaking: false, - }, - ], + updateStream: { + fieldTransforms: [ + { + transformType: 'add_field', + fieldName: ['Second new column'], + breaking: false, + }, + { + transformType: 'add_field', + fieldName: ['New column of nulls'], + breaking: false, + }, + ], + }, }, ], },