Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
make test
?make test-docker
?make lint
before submission?Added
qcir::QCir::calculate_gate_times()
to replaceqcir::QCirGate::get_time()
qcir::QCir::append(GateType, QubitIdList)
qcir::QCir::prepend(GateType, QubitIdList)
Changed
qcir::QCir::get_gates()
now also returns a topologically sorted list to prevent confusion caused by multiple get-gates APIs.qcir::QCir::get_gate(size_t id)
now returns the gate inqcir::QCir
now automatically maintains its topological gate orders---The user no longer need to update it manually.Fixed
qcir::QCir
not freeing the memory it allocates correctlyqcir::Optimizer
not freeing the memory it allocates correctlyRemoved
qcir::QCirGate::get_time()
: the info it returns is always unreliable.qcir::QCirGate
's traversal pin members.qcir::QCir::get_topologically_ordered_gates()
and other topological order-related features: rendered useless with the above changes