Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission errors not showing #3972

Open
Atmire-Kristof opened this issue Feb 11, 2025 · 0 comments · May be fixed by #3973
Open

Submission errors not showing #3972

Atmire-Kristof opened this issue Feb 11, 2025 · 0 comments · May be fixed by #3973
Assignees
Labels
bug component: submission error handling How errors are handled from REST API

Comments

@Atmire-Kristof
Copy link
Contributor

Describe the bug

In very specific custom submission setups, it is possible errors shown on top of the submission sections are not displayed at all, when they should be present. In those cases, the section is also marked as valid when it shouldn't.

To Reproduce

First, set up the project with the following conditions in the backend:

  • In item-submission.xml, configure a submission definition containing two steps with type "submission-form" (e.g. "traditionalpageone" and "traditionalpagetwo")
  • Modify (or configure a different) MetadataValidation to add section-wide errors (/sections/{sectionId}). By default, this validation will only allow metadata field errors, but this bug requires section-wide errors.

Next, start a submission in the configured form and:

  • In one of the two "submission-form" sections, fill in any value of any of the fields
  • In the other section, perform an action that would result in the custom section-wide error

If the setup is correct, this should result in NO section-wide error (at the top of the section) being displayed for the relevant section.
If the other section is left empty, the error does display.

Expected behavior

The error should always display when the conditions are met, regardless of the other sections within the submission.

@Atmire-Kristof Atmire-Kristof added bug needs triage New issue needs triage and/or scheduling labels Feb 11, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Feb 11, 2025
@Atmire-Kristof Atmire-Kristof linked a pull request Feb 11, 2025 that will close this issue
12 tasks
@tdonohue tdonohue added component: submission error handling How errors are handled from REST API and removed needs triage New issue needs triage and/or scheduling labels Feb 11, 2025
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: submission error handling How errors are handled from REST API
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants