Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize linting performance by disabling "heavy" warning rules #2864

Open
ybnd opened this issue Mar 14, 2024 · 0 comments
Open

Optimize linting performance by disabling "heavy" warning rules #2864

ybnd opened this issue Mar 14, 2024 · 0 comments
Labels
bug code task help wanted Needs a volunteer to claim to move forward

Comments

@ybnd
Copy link
Member

ybnd commented Mar 14, 2024

Describe the bug
In my experience, we tend not to pay much attention to ESLint warnings as we do breaking errors.
However, it appears that some warning rules are among the most impactful rules in our linting configuration:

  • import/no-deprecated
  • deprecation/deprecated
  • @typescript-eslint/no-floating-promises
  • @typescript-eslint/no-misused-promises

Especially during CI builds it seems counterproductive to do the work of checking these warnings, if we run with --quiet anyway.

We could save about 20s by setting these rules to "off".

To Reproduce
Steps to reproduce the behavior:

  1. Run ESLint ~ TIMING=1 yarn run eslint . --quiet
  2. Go over the rules in the "top 10" view, you'll see that many of them are only warnings

Related work
#2343

@ybnd ybnd added bug needs triage New issue needs triage and/or scheduling labels Mar 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 14, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward code task and removed needs triage New issue needs triage and/or scheduling labels May 1, 2024
@tdonohue tdonohue removed this from DSpace Backlog May 1, 2024
@tdonohue tdonohue moved this to 📋 To Do in DSpace 9.0 Release May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code task help wanted Needs a volunteer to claim to move forward
Projects
Status: 📋 To Do
Development

No branches or pull requests

2 participants