Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] Faded text (for long abstracts / text blocks) may be seen as insufficient color contrast & as "content lost" on small screens #1164

Open
tdonohue opened this issue May 7, 2021 · 6 comments
Assignees
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back e/8 Estimate in hours funded Task is funded via the DSpace Development Fund low priority

Comments

@tdonohue
Copy link
Member

tdonohue commented May 7, 2021

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Deque Analysis Summary

Two "serious" issues with faded text:

1. Faded text triggers insufficient color contrast errors
When viewing a list of Items, sometimes faded text will appear (for long lists of authors, or a long description/abstract). This is most easily seen in the Search Results (especially the grid view): https://demo7.dspace.org/search?spc.page=1&query=test&spc.sf=score&spc.sd=DESC

This text's purpose is to signify that additional text is available -- if you click on the text, it will expand to show the entire text.

However, this faded text was noted in "manual" testing by the Deque team as having color contrast issues. Obviously, this is expected behavior for text that fades away....it is not meant to be entirely readable.

Deque issue ticket IDs: 472737

2. Faded text triggers "content lost" errors
When testing on small screens (320px width) or zoomed at 200%, this triggers more text to be faded. The text again can still be clicked to be viewed, but it was noted by the Deque team as "content lost"

See for example these ticket IDs (all include screenshots): 470760, 470757, 470752

Recommended Fix

Unclear how/whether this should be resolved (labeling as low priority), as this almost seems like a "false positive". However, I wanted to capture these results from the Deque Analysis in case we find it more problematic with additional testing.

We might consider thinking of a way to make it more obvious that the text is clickable to expand....that may make it clear that the fading text is purposeful & that clicking it will "unfade it" and show all the content.

Alternatively, we could consider replacing the "fading text" with a simple three dots (ellipsis) ..., which is a more common representation of "text overflow" (e.g. text-overflow: ellipsis is valid in CSS: https://www.w3schools.com/cssref/css3_pr_text-overflow.asp). Or we could clip the text at the nearest space (i.e. not clip mid-word, but between words) without fading.

More Information / Tools

@tdonohue
Copy link
Member Author

tdonohue commented May 7, 2021

@artlowel : I'd appreciate your feedback here...but this is low priority as I think it may be a "false positive" (it was only found from manual testing, not automated, so it might be confusion over how this feature works). That said, if you have feedback or ideas, let me know.

@tdonohue tdonohue changed the title [Deque Analysis] Faded text (for long abstracts / text blocks) may be seen as insufficient color contrast [Deque Analysis] Faded text (for long abstracts / text blocks) may be seen as insufficient color contrast & as "content lost" on small screens May 12, 2021
@tdonohue tdonohue modified the milestones: 7.0, 7.1 Jul 28, 2021
@tdonohue tdonohue removed this from the 7.1 milestone Oct 27, 2021
@tdonohue tdonohue moved this to 🙋 Needs Help / Unscheduled in DSpace Backlog Mar 9, 2023
@tdonohue tdonohue added the help wanted Needs a volunteer to claim to move forward label Mar 9, 2023
@DanGastardelli
Copy link
Contributor

DanGastardelli commented May 24, 2024

Good afternoon @tdonohue!

We at Neki-it made 2 models for analysis, follow the models below:

Example 1 (changing button text and changing position)
exemplo_1

Example 2 (just changing button text)
exemplo_2

Would any of them meet the demand?

Waiting for feedback!

@tdonohue
Copy link
Member Author

@DanGastardelli : I'm not sure I know of the best solution here, so I'm finding it hard to recommend a next step. As you can tell from the ticket description, there was not a clear "solution" chosen yet.

Personally, though, I don't think changing the text from "Show more" to "Read more" provides any significant improvement. Other ideas have already been suggested in #2573. But, the core issue wasn't in the name of the link..it was that the link's purpose and the faded text were unclear to the accessibility analyzer.

I'm also worried that this ticket may overlap with #3073, which is already assigned. So, we may want to wait on the solution to #3073 before doing something simple like changing the text of this link.

@atarix83
Copy link
Contributor

@tdonohue

i think replacing the "fading text" with a simple three dots (ellipsis) ... is the best solution. i'd leave the show more button as is

@atarix83
Copy link
Contributor

@tdonohue

We can work on this. it's about 8h

@tdonohue
Copy link
Member Author

Thanks @atarix83 ! I'll assign it to you and add the estimate

@tdonohue tdonohue added e/8 Estimate in hours and removed Estimate TBD labels Feb 13, 2025
@tdonohue tdonohue added claimed: 4Science 4Science team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund and removed help wanted Needs a volunteer to claim to move forward labels Feb 13, 2025
@tdonohue tdonohue moved this to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Feb 13, 2025
@tdonohue tdonohue added affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back e/8 Estimate in hours funded Task is funded via the DSpace Development Fund low priority
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

4 participants