Skip to content

Commit

Permalink
Remove source links
Browse files Browse the repository at this point in the history
  • Loading branch information
@ryon @carlosfelix2
ryon authored and carlosfelix2 committed Jan 23, 2025
1 parent 40973b9 commit f47b949
Show file tree
Hide file tree
Showing 12 changed files with 9 additions and 381 deletions.
7 changes: 5 additions & 2 deletions client/cypress/support/step_definitions/commonSteps.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,14 @@ When(`I click on the {string} button in the navigation`, (page) => {

When(`I look for the {string} CTA`, (ctaString) => {
cy.get(`[data-cy="${hyphenizeString(ctaString)}-block"]`).as('CTA_block');
cy.get('@CTA_block').scrollIntoView().should('be.visible');
cy.get('@CTA_block').scrollIntoView();
cy.get('@CTA_block').should('be.visible');
});

When(`I look for the {string}`, (footer) => {
cy.get(`[data-cy="${hyphenizeString(footer)}-primary-block"]`).scrollIntoView().should('be.visible');
cy.get(`[data-cy="${hyphenizeString(footer)}-primary-block"]`).as('string_block');
cy.get('@string_block').scrollIntoView();
cy.get('@string_block').should('be.visible');
});

// Common Thens:
Expand Down
5 changes: 0 additions & 5 deletions client/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 0 additions & 15 deletions client/src/components/J40Footer/J40Footer.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ import LinkTypeWrapper from '../LinkTypeWrapper';
import SurveyButton from '../SurveyButton';

// @ts-ignore
import {GITHUB_LINK, GITHUB_LINK_ES} from '../../constants';
import {PAGES_ENDPOINTS} from '../../data/constants';
import * as ABOUT_COPY from '../../data/copy/about';
import * as COMMON_COPY from '../../data/copy/common';
import whitehouseIcon from '../../images/eop-seal.svg';

Expand Down Expand Up @@ -64,19 +62,6 @@ const J40Footer = () => {
dataCy={hyphenizeString(COMMON_COPY.FOOTER.FIND_CONTACT.defaultMessage)}
/>,
],
[
intl.formatMessage(COMMON_COPY.FOOTER.CONTRIBUTE),
<LinkTypeWrapper
linkText={intl.formatMessage(COMMON_COPY.FOOTER.GITHUB_LINK_TEXT)}
internal={false}
url={intl.locale === 'es' ? GITHUB_LINK_ES : GITHUB_LINK}
openUrlNewTab={true}
className={'footer-link-first-child'}
key={'contactlink'}
dataCy={hyphenizeString(COMMON_COPY.FOOTER.GITHUB_LINK_TEXT.defaultMessage)}
tag={intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_LINK_TAG)}
/>,
],
];

// see https://designsystem.digital.gov/components/footer/
Expand Down
35 changes: 0 additions & 35 deletions client/src/components/J40Footer/__snapshots__/J40Footer.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,41 +114,6 @@ exports[`J40Footer renders correctly 1`] = `
</ul>
</section>
</div>
<div
class="mobile-lg:grid-col-12 desktop:grid-col-4"
>
<section>
<div
class="j40-h4"
>
Want to contribute?
</div>
<ul
class="usa-list usa-list--unstyled"
>
<li
class="usa-footer__secondary-link"
>
<a
class="usa-link usa-link--external footer-link-first-child"
data-cy="check-out-the-code-on-github"
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check out the code on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</li>
</ul>
</section>
</div>
</div>
</div>
</div>
Expand Down
19 changes: 3 additions & 16 deletions client/src/pages/about.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import J40MainGridContainer from '../components/J40MainGridContainer';
import Layout from '../components/layout';
import SubPageNav from '../components/SubPageNav';

import {GITHUB_LINK, GITHUB_LINK_ES} from '../constants';
import {DATA_SURVEY_LINKS, PAGES_ENDPOINTS, USWDS_BREAKPOINTS} from '../data/constants';
import * as ABOUT_COPY from '../data/copy/about';
import {FEEDBACK_EMAIL} from '../data/copy/common';
Expand All @@ -20,8 +19,6 @@ import {FEEDBACK_EMAIL} from '../data/copy/common';
import commentIcon from // @ts-ignore
'/node_modules/uswds/dist/img/usa-icons/comment.svg';

import githubIcon from // @ts-ignore
'/node_modules/uswds/dist/img/usa-icons/github.svg';

interface IAboutPageProps {
location: Location;
Expand Down Expand Up @@ -113,19 +110,9 @@ const AboutPage = ({location}: IAboutPageProps) => {
</p>
</AboutCard>

<AboutCard
size={'small'}
imgSrc={githubIcon}
header={intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_HEADING)}
linkText={intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_LINK_TEXT)}
linkTag={intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_LINK_TAG)}
url={intl.locale === 'es' ? GITHUB_LINK_ES : GITHUB_LINK}
openUrlNewTab={true}
internal={false}>
<p>
{intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_INFO)}
</p>
</AboutCard>
<div className='grid-gap-lg tablet:grid-col'>
{/* spacer */}
</div>
</AboutCardsContainer>

<Grid col={12} tablet={{col: 8}}>
Expand Down
99 changes: 1 addition & 98 deletions client/src/pages/tests/__snapshots__/about.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -558,69 +558,7 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
</div>
<div
class="grid-gap-lg tablet:grid-col"
data-testid="grid"
>
<div
class="grid-row j40-aboutcard-sm-card"
data-testid="grid"
>
<div
class="tablet:grid-col-2 j40-aboutpage-image-container"
data-testid="grid"
>
<img
alt="Join the open source community"
class="j40-aboutcard-image"
src="test-file-stub"
/>
</div>
<div
class="tablet:grid-col-9"
data-cy="join-the-open-source-community-block"
data-testid="grid"
>
<div
class="grid-row"
data-testid="grid"
>
<h3>
Join the open source community
</h3>
<p>
The tool’s code is open source, which means it is available for the public to view and contribute to it.
</p>
<div
class="j40-aboutcard-sm-link"
>
<a
class="usa-link usa-link--external"
data-cy=""
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check it out on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</div>
</div>
</div>
<div
class="grid-col-1"
data-testid="grid"
>
</div>
</div>
</div>
/>
</div>
<div
class="grid-col-12 tablet:grid-col-8"
Expand Down Expand Up @@ -784,41 +722,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
</ul>
</section>
</div>
<div
class="mobile-lg:grid-col-12 desktop:grid-col-4"
>
<section>
<div
class="j40-h4"
>
Want to contribute?
</div>
<ul
class="usa-list usa-list--unstyled"
>
<li
class="usa-footer__secondary-link"
>
<a
class="usa-link usa-link--external footer-link-first-child"
data-cy="check-out-the-code-on-github"
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check out the code on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</li>
</ul>
</section>
</div>
</div>
</div>
</div>
Expand Down
35 changes: 0 additions & 35 deletions client/src/pages/tests/__snapshots__/contact.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -569,41 +569,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
</ul>
</section>
</div>
<div
class="mobile-lg:grid-col-12 desktop:grid-col-4"
>
<section>
<div
class="j40-h4"
>
Want to contribute?
</div>
<ul
class="usa-list usa-list--unstyled"
>
<li
class="usa-footer__secondary-link"
>
<a
class="usa-link usa-link--external footer-link-first-child"
data-cy="check-out-the-code-on-github"
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check out the code on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</li>
</ul>
</section>
</div>
</div>
</div>
</div>
Expand Down
35 changes: 0 additions & 35 deletions client/src/pages/tests/__snapshots__/downloads.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -701,41 +701,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
</ul>
</section>
</div>
<div
class="mobile-lg:grid-col-12 desktop:grid-col-4"
>
<section>
<div
class="j40-h4"
>
Want to contribute?
</div>
<ul
class="usa-list usa-list--unstyled"
>
<li
class="usa-footer__secondary-link"
>
<a
class="usa-link usa-link--external footer-link-first-child"
data-cy="check-out-the-code-on-github"
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check out the code on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</li>
</ul>
</section>
</div>
</div>
</div>
</div>
Expand Down
35 changes: 0 additions & 35 deletions client/src/pages/tests/__snapshots__/freqAskedQuestions.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1231,41 +1231,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
</ul>
</section>
</div>
<div
class="mobile-lg:grid-col-12 desktop:grid-col-4"
>
<section>
<div
class="j40-h4"
>
Want to contribute?
</div>
<ul
class="usa-list usa-list--unstyled"
>
<li
class="usa-footer__secondary-link"
>
<a
class="usa-link usa-link--external footer-link-first-child"
data-cy="check-out-the-code-on-github"
href="https://github.com/DOI-DO/ceq-j40-cejst-2"
rel="noreferrer"
target="_blank"
>
Check out the code on GitHub
</a>
 
<span
class="usa-tag "
data-testid="tag"
>
New Location
</span>
</li>
</ul>
</section>
</div>
</div>
</div>
</div>
Expand Down
Loading

0 comments on commit f47b949

Please sign in to comment.