From 89b1a845104de22ca610112a0d5421ce63ede7ac Mon Sep 17 00:00:00 2001 From: Ross Oliver Date: Mon, 25 Nov 2024 12:20:48 +0000 Subject: [PATCH] Fix Sentry not sending events There is a bug in the JS event filtering; we get an error that `Error` is not defined. I expect this maybe should be a `TypeError` as in the other JS-related before-send method, but I'm not certain. Removing for now so that we start getting Sentry events through again. --- config/initializers/sentry.rb | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/config/initializers/sentry.rb b/config/initializers/sentry.rb index a7336dec24a..b338bcc9579 100644 --- a/config/initializers/sentry.rb +++ b/config/initializers/sentry.rb @@ -1,22 +1,5 @@ # frozen_string_literal: true -FILTERABLE_JS_ERRORS = [ - "Failed to fetch", - "NetworkError when attempting to fetch resource.", -].freeze - -def cookie_banner_js_event?(event, hint) - hint[:exception].is_a?(Error) && - event.tags["mechanism"] == "onunhandledrejection" && - event.exception.values.any? { |ex| ex.value.include?("[object Response]") } -end - -def filterable_js_event?(event, hint) - hint[:exception].is_a?(TypeError) && event.exception.values.any? do |exception| - FILTERABLE_JS_ERRORS.include?(exception.value) - end -end - Sentry.init do |config| config.enabled_environments = %w[production sandbox staging review] config.dsn = config.enabled_environments.include?(Rails.env) ? Rails.application.credentials.SENTRY_DSN : "disabled" @@ -24,9 +7,7 @@ def filterable_js_event?(event, hint) config.release = "#{ENV['RELEASE_VERSION']}-#{ENV['SHA']}" filter = ActiveSupport::ParameterFilter.new(Rails.application.config.filter_parameters) - config.before_send = lambda do |event, hint| - return nil if filterable_js_event?(event, hint) || cookie_banner_js_event?(event, hint) - + config.before_send = lambda do |event| # use Rails' parameter filter to sanitize the event filter.filter(event.to_hash) end