Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Column Metadata #231

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Add Column Metadata #231

merged 1 commit into from
Jun 28, 2020

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jun 22, 2020

This is a follow-up to PR #187 that seems to be stalled as the original poster seems to be no longer active). I took the changes and refactored them.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #231 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   94.20%   94.59%   +0.38%     
==========================================
  Files          18       19       +1     
  Lines         915      980      +65     
==========================================
+ Hits          862      927      +65     
  Misses         38       38              
  Partials       15       15              
Impacted Files Coverage Δ
rows.go 89.13% <ø> (ø)
sqlmock.go 93.30% <ø> (ø)
sqlmock_before_go18.go 100.00% <ø> (ø)
column.go 100.00% <100.00%> (ø)
expectations_go18.go 95.45% <100.00%> (+0.71%) ⬆️
rows_go18.go 92.85% <100.00%> (+21.42%) ⬆️
sqlmock_go18.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b99664...3b533ba. Read the comment docs.

@alespour alespour marked this pull request as ready for review June 22, 2020 20:32
@l3pp4rd
Copy link
Member

l3pp4rd commented Jun 27, 2020

Thanks, will have a look the coming week

@l3pp4rd l3pp4rd merged commit b8a63d3 into DATA-DOG:master Jun 28, 2020
@l3pp4rd
Copy link
Member

l3pp4rd commented Jun 28, 2020

will check for a while if people find any bugs in master before tagging a release, thanks

@alespour
Copy link
Contributor Author

alespour commented Aug 12, 2020

will check for a while if people find any bugs in master before tagging a release, thanks

@l3pp4rd what do you think, is it ok now for a new release? Thank you.
btw I'm glad you seem to have found new maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants