From fa9ee9176115a5a78c9192a6065d75478fd8268b Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Fri, 13 Dec 2024 14:50:10 -0500 Subject: [PATCH 1/3] fix(falcon_install): fixes issue where failure to download wasn't apparent Fixes #577 This PR adds better failure message when a user uses falcon_sensor_version_decrement on newly supported linux OS's. Before, it would just fail when trying to download a sensor with an incorrect list index value. --- roles/falcon_install/tasks/api.yml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/roles/falcon_install/tasks/api.yml b/roles/falcon_install/tasks/api.yml index 028f521..cdccc80 100644 --- a/roles/falcon_install/tasks/api.yml +++ b/roles/falcon_install/tasks/api.yml @@ -54,11 +54,23 @@ register: falcon_api_installer_list delegate_to: localhost -- name: CrowdStrike Falcon | Validate Sensor request +- name: CrowdStrike Falcon | Validate sensor request ansible.builtin.fail: - msg: "No Falcon Sensor was found! If passing in falcon_sensor_version, ensure it is correct!" + msg: "No Falcon sensor was found! If passing in falcon_sensor_version, ensure it is correct!" when: falcon_api_installer_list.installers[0] is not defined +- name: CrowdStrike Falcon | Validate available sensor count > decrement (if applicable) + ansible.builtin.assert: + that: + - falcon_api_installer_list.installers | length > falcon_sensor_version_decrement + fail_msg: + "Not enough sensor versions available for the specified decrement value: N-{{ falcon_sensor_version_decrement }}. + This may occur if your OS distribution/version is newly supported and fewer + historical sensor versions exist." + when: + - falcon_sensor_version_decrement is defined + - falcon_sensor_version_decrement > 0 + - name: CrowdStrike Falcon | Ensure download path exists (local) ansible.builtin.file: path: "{{ falcon_api_sensor_download_path }}" From 80a6e4f9a5fbea3f521471e4bfe5df21f39dc513 Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Fri, 13 Dec 2024 14:54:10 -0500 Subject: [PATCH 2/3] chore: add changelog fragment --- changelogs/fragments/577-decrement.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/577-decrement.yml diff --git a/changelogs/fragments/577-decrement.yml b/changelogs/fragments/577-decrement.yml new file mode 100644 index 0000000..d8826f9 --- /dev/null +++ b/changelogs/fragments/577-decrement.yml @@ -0,0 +1,2 @@ +bugfixes: + - falcon_install - fixes issue where failure to download sensor weren't apparent (https://github.com/CrowdStrike/ansible_collection_falcon/pull/588) From 67bc54e9eb8eea5e344cb1f55eaf9b00830815ae Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Fri, 13 Dec 2024 15:04:56 -0500 Subject: [PATCH 3/3] Update 577-decrement.yml --- changelogs/fragments/577-decrement.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/577-decrement.yml b/changelogs/fragments/577-decrement.yml index d8826f9..873b434 100644 --- a/changelogs/fragments/577-decrement.yml +++ b/changelogs/fragments/577-decrement.yml @@ -1,2 +1,2 @@ bugfixes: - - falcon_install - fixes issue where failure to download sensor weren't apparent (https://github.com/CrowdStrike/ansible_collection_falcon/pull/588) + - falcon_install - improves error message when using falcon_sensor_version_decrement but not enough historical sensors are available (https://github.com/CrowdStrike/ansible_collection_falcon/pull/588)