feat: implement scenario run duration tracking

Cosmo-Tech · Feb 16, 2022 · 4fc8523 · 4fc8523
1 parent 7c4ff05
commit 4fc8523
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/src/services/AppInsights.js b/src/services/AppInsights.js
@@ -60,7 +60,7 @@ class AppInsightsSingleton {
 
   trackScenarioRunDuration(runDuration) {
     if (this.enabled) {
-      this.appInsights.trackMetric({ name: 'RunDurationValue', average: runDuration, sampleCount: runDuration });
+      this.appInsights.trackMetric({ name: 'RunDurationValue', average: runDuration });
     }
   }
 }

diff --git a/src/state/sagas/scenario/LaunchScenario/LaunchScenario.js b/src/state/sagas/scenario/LaunchScenario/LaunchScenario.js
@@ -29,10 +29,12 @@ export function* launchScenario(action) {
     yield call(Api.ScenarioRuns.runScenario, ORGANIZATION_ID, workspaceId, scenarioId);
 
     // Start backend polling to update the scenario status
+    const runStartTime = new Date().getTime();
     yield put({
       type: SCENARIO_ACTIONS_KEY.START_SCENARIO_STATUS_POLLING,
       workspaceId: workspaceId,
       scenarioId: scenarioId,
+      startTime: runStartTime,
     });
   } catch (e) {
     console.error(e);

diff --git a/src/state/sagas/scenario/PollScenarioState/PollScenarioState.js b/src/state/sagas/scenario/PollScenarioState/PollScenarioState.js
@@ -6,6 +6,9 @@ import { SCENARIO_ACTIONS_KEY } from '../../../commons/ScenarioConstants';
 import { ORGANIZATION_ID } from '../../../../config/AppInstance';
 import { Api } from '../../../../services/config/Api';
 import { SCENARIO_STATUS_POLLING_DELAY } from '../../../../config/AppConfiguration';
+import { AppInsights } from '../../../../services/AppInsights';
+
+const appInsights = AppInsights.getInstance();
 
 function forgeStopPollingAction(scenarioId) {
   let actionName = SCENARIO_ACTIONS_KEY.STOP_SCENARIO_STATUS_POLLING;
@@ -31,8 +34,17 @@ export function* pollScenarioState(action) {
         // Update the scenario state in all scenario redux states
         yield put({
           type: SCENARIO_ACTIONS_KEY.UPDATE_SCENARIO,
-          data: { scenarioState: data.state, scenarioId: action.scenarioId, lastRun: data.lastRun },
+          data: {
+            scenarioState: data.state,
+            scenarioId: action.scenarioId,
+            lastRun: data.lastRun,
+          },
         });
+        if (action.startTime) {
+          const runFinishTime = new Date().getTime();
+          const runDuration = (runFinishTime - action.startTime) / 1000;
+          appInsights.trackScenarioRunDuration(runDuration);
+        }
         // Stop the polling for this scenario
         yield put(forgeStopPollingAction(action.scenarioId));
       }

diff --git a/src/state/sagas/scenario/UpdateAndLaunchScenario/UpdateAndLaunchScenario.js b/src/state/sagas/scenario/UpdateAndLaunchScenario/UpdateAndLaunchScenario.js
@@ -21,10 +21,14 @@ export function* updateAndLaunchScenario(action) {
   try {
     appInsights.trackScenarioLaunch();
     // Update scenario parameters
+    const runStartTime = new Date().getTime();
     yield put({
       type: SCENARIO_ACTIONS_KEY.SET_CURRENT_SCENARIO,
       status: STATUSES.SAVING,
-      scenario: { state: SCENARIO_RUN_STATE.RUNNING, parametersValues: scenarioParameters },
+      scenario: {
+        state: SCENARIO_RUN_STATE.RUNNING,
+        parametersValues: scenarioParameters,
+      },
     });
     const { data: updateData } = yield call(
       Api.Scenarios.updateScenario,
@@ -49,6 +53,7 @@ export function* updateAndLaunchScenario(action) {
       type: SCENARIO_ACTIONS_KEY.START_SCENARIO_STATUS_POLLING,
       workspaceId: workspaceId,
       scenarioId: scenarioId,
+      startTime: runStartTime,
     });
   } catch (e) {
     console.error(e);