Redundant logic in ThresholdResponse multisigs

[0xekez]

The logic for determining if a proposal is passed for a multisig with a ThresholdResponse includes an option for considering a expired proposal as passed:

cw-plus/contracts/cw3-fixed-multisig/src/state.rs

Lines 78 to 81 in 5c871af

	if self.expires.is_expired(block) {
	// If expired, we compare Yes votes against the total number of votes (minus abstain).
	let opinions = self.votes.total() - self.votes.abstain;
	self.votes.yes >= votes_needed(opinions, threshold)

That condition will never be reached though as the proposal's status is only updated on a vote. It is impossible to vote on an expired proposal so there will never be an update_status call which will flip such a proposal to Status::Passed.

It is only possible to execute a passed proposal which has been set to passed via a call to update_status:

cw-plus/contracts/cw3-fixed-multisig/src/contract.rs

Lines 189 to 191 in 5c871af

	if prop.status != Status::Passed {
	return Err(ContractError::WrongExecuteStatus {});
	}

Open to thoughts here. Seems to me that logic should either be removed or the status check should call prop.current_status() instead of using the one in storage.