Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered Hooks (cw0) should have a "kind" #176

Closed
ethanfrey opened this issue Dec 11, 2020 · 0 comments · Fixed by #195
Closed

Registered Hooks (cw0) should have a "kind" #176

ethanfrey opened this issue Dec 11, 2020 · 0 comments · Fixed by #195
Assignees

Comments

@ethanfrey
Copy link
Member

Right now we just store an address. This assumes that there is exactly one type of hook registered for a given contract.

What if we have multiple types of events? eg. change membership and change admin? we could add some more info to track that and let the module decide. I guess it should be able to list all hooks given the event - could store as a key in a map, or multiple maps... we probably need to refactor that module a bit in either case.

@ethanfrey ethanfrey self-assigned this Dec 18, 2020
@ethanfrey ethanfrey mentioned this issue Dec 20, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant