-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archiver queried for values even if ncount=0 #2575
Comments
No idea, that's internal to the archive appliance client implementation
Yes, if you know that there are no values, then the call could return an empty value iterator
The goal here is to decide if we can return the raw data (count is below some threshold "count"), or if we should return "optimized" min/max/average type of data because there are way too many rows of raw data. |
Sure, but ncount=0 should indicate that there's no point getting raw data at all. Right? I'm asking this since we have added new archiver clusters and now have a total of 4. Which means each plot will make the data browser send off a lot of requests. In view of how we organize these clusters over time only one of them will have the wanted data. |
Yes, if you know that there are no values, then the call could return an empty value iterator |
In
ApplianceArchiverReader
L140 the archiver(s) are queried for the number of data points callinggetNumberOfPoints
which - no points are found - will callgetNumberOfPointsLegacy
.Now if this chain of calls returns zero, then the archiver is called to retrieve raw values anyway.
So I have some questions:
getNumberOfPointsLegacy
needed? Is this related to certain versions of the archiver appliance? If so, then it should be possible to omit the call if only newer versions are used.getNumberOfPoints
in the first place?I'm asking this since we are migrating to a new clusters, but we're not migrating data. So Phoebus needs to query twice as many endpoints for each plot, putting load on both the application and the archiver services. And network.
The text was updated successfully, but these errors were encountered: