Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenDisplay action side effects on Linux and Windows #2394

Closed
georgweiss opened this issue Sep 21, 2022 · 2 comments
Closed

OpenDisplay action side effects on Linux and Windows #2394

georgweiss opened this issue Sep 21, 2022 · 2 comments

Comments

@georgweiss
Copy link
Collaborator

georgweiss commented Sep 21, 2022

My users have spotted a new behavior when an action opens a display with target "New Window": the new window will be rendered, resized and moved, but unfortunately put behind the window from which the action was invoked. Upon next action the window - as it already is available - is put to front.

Initial conclusion was that first time the window is not rendered, but this is not the case. It's simply obscured.

Note that this was seen on CentOS7 with xcfe. This behavior is not seen on MacOS (Monterrey). Windows not tested.

If I comment out in DockStage:

 stage.setAlwaysOnTop(true);
 stage.setAlwaysOnTop(false);

I get the wanted/expcted behavior on CentOS7, and I cannot spot any other side effects from commenting these lines.
Seems this was added in commit ecbe7ea.

@kasemir
Copy link
Collaborator

kasemir commented Sep 21, 2022

The somewhat overkill sequence of

stage.show();
stage.toFront();
stage.setAlwaysOnTop(true);
stage.setAlwaysOnTop(false);

was suggested in #2341 as a part of supporting target=window@1038.. but I think allowing to set the location and size is fundamentally different from popping the window to the front. If the plain show() suffices, I say go with that.

@georgweiss georgweiss changed the title OpenDisplay action side effects on Linux OpenDisplay action side effects on Linux and Windows Sep 22, 2022
@georgweiss
Copy link
Collaborator Author

For the sake of completeness: the observed issue was also seen on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants