Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log scale for Tank widget #2323

Closed
zhangt58 opened this issue Jul 11, 2022 · 4 comments
Closed

Log scale for Tank widget #2323

zhangt58 opened this issue Jul 11, 2022 · 4 comments

Comments

@zhangt58
Copy link

It seems there is no property configuration for the LogScale of Tank widget? Or do you have an alternative solution to present a single scalar data in a bar plot?

@kasemir
Copy link
Collaborator

kasemir commented Jul 11, 2022

The tank representation, https://github.com/ControlSystemStudio/phoebus/blob/master/app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/TankRepresentation.java, is based on the https://github.com/ControlSystemStudio/phoebus/blob/master/app/rtplot/src/main/java/org/csstudio/javafx/rtplot/RTTank.java, and in there one can basically say axis.setLogarithmic(true) or false.
So the hard part is done, there's simply no property on the tank widget to configure that.
@tanviash , do you have somebody to add that?

@tanviash
Copy link
Collaborator

@kasemir Yes, I can work on adding this.

@kasemir
Copy link
Collaborator

kasemir commented Jul 11, 2022

Great, thanks

@kasemir
Copy link
Collaborator

kasemir commented Jul 20, 2022

Implemented by #2327

@kasemir kasemir closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants