Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED with label not rendered correctly #2199

Closed
georgweiss opened this issue Mar 31, 2022 · 3 comments
Closed

LED with label not rendered correctly #2199

georgweiss opened this issue Mar 31, 2022 · 3 comments

Comments

@georgweiss
Copy link
Collaborator

A user has created an OPI heavily using the LED widget together with a label. When initially loaded some of the widgets do not render the label text and user will need to reload display once or twice before all labels are rendered as expected.

Not calling pane.setManaged(false); in createJFXNode, or calling jfx_node.layout() and the end of updateChanges in BaseLEDRepresentation seems to solve the issue.

@kasemir, any thoughts?

@kasemir
Copy link
Collaborator

kasemir commented Apr 4, 2022

setManaged(false) was added to several widgets because it dramatically improved rendering speed.
Details might by now have changed, and we have reverted back to using managed mode on several widgets because it simply became to hard to find the correct location for calling layout, and without layout, there were rendering errors.

Still, as step 1 I'd try adding the appropriate layout call, and if that works out, fine.
Fallback would be to revert all the way back to using managed mode, but if possible I'd avoid that because especially with many "simple" widgets managed mode resulted in endless recursions inside the JFX rendering code.

@georgweiss
Copy link
Collaborator Author

OK, thanks @kasemir. I will try to determine if call to layout() will indeed resolve the issue at hand and create a PR form that.

@kasemir
Copy link
Collaborator

kasemir commented Apr 7, 2022

Assume fixed by 2202

@kasemir kasemir closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants