Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Rewards always go to coinbase #1542

Closed
antonydenyer opened this issue Oct 19, 2022 · 0 comments · Fixed by #1547
Closed

Gas Rewards always go to coinbase #1542

antonydenyer opened this issue Oct 19, 2022 · 0 comments · Fixed by #1547
Assignees

Comments

@antonydenyer
Copy link
Contributor

antonydenyer commented Oct 19, 2022

QBFT uses the minerbase (coinbase) as part of the consensus algorithm when signing blocks. This is used to verify if a block proposal comes from someone that has permissions to do so and is the current leader.

Currently when gas is enabled gas rewards always go to the address specified in the header.coinbase field ie the validator. We should be able to configure where those rewards go to using a transition

"config": {
 ...
    "transitions": [
      {
        "block": 10,
        "beneficaryMode": "fixed"
        "miningBeneficiary": "0x123.."
      }
  ]
}

This will send all gas rewards to the account 0x123... Note in this scenario there is no block reward.
If a single transfer transaction is mined at block 10 then the sending account will be deducted 21000 and the miningBeneficiary will be rewarded 21000.

To transition back to the default behaviour of rewarding the validator with the gas you should be able to specify a transition to achieve this:

"config": {
 ...
    "transitions": [
      {
        "block": 20,
        "beneficaryMode": "coinbase"
      }
  ]
}

@antonydenyer antonydenyer changed the title Add the ability to setEtherbase using transitions Gas Rewards always go to coinbase Oct 31, 2022
@antonydenyer antonydenyer self-assigned this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant