Hashicorp connection, override http protocol version #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siladu
reviewed
Jun 26, 2023
| return httpProtocolVersion; | ||
| } | ||
|
|
||
| public static final class Builder { |
There was a problem hiding this comment.
Yes, I realised that this class is used in our tests as well and we were forced to set values that were not required by the specific tests. Builder patterns neatly allows the defaults to be set.
acceptance-tests/src/test/java/tech/pegasys/web3signer/dsl/utils/MetadataFileHelpers.java
Show resolved
Hide resolved
...ance-tests/src/test/java/tech/pegasys/web3signer/tests/signing/BlsSigningAcceptanceTest.java
Show resolved
Hide resolved
...e/src/main/java/tech/pegasys/web3signer/keystorage/hashicorp/HashicorpConnectionFactory.java
Show resolved
Hide resolved
siladu
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Hashicorp connection, override http protocol version. Hashicorp Signing Metadata file can now optionally take
httpProtocolVersionwith possible values ofHTTP_1_1andHTTP_2. It defaults toHTTP_2. This should help in situations where vault is behind load balancer/vault agent and unable to handle Http 2 connections over h2c.Fixed Issue(s)
fixes #811
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing