Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove example ThermalTest? #3596

Closed
psychocoderHPC opened this issue Apr 20, 2021 · 4 comments
Closed

remove example ThermalTest? #3596

psychocoderHPC opened this issue Apr 20, 2021 · 4 comments
Assignees
Labels
component: examples PIConGPU or PMacc examples component: tests unit tests

Comments

@psychocoderHPC
Copy link
Member

Evaluate if the example ThermalTest can be removed.
For years nobody executed this example, it is not clear if it is useful to keep it.

todo if we keep it

  • port python scripts to python3
  • move the example into share/picongpu/tests
  • add an automatic script to perform the test which is returning true/false depending on the test result (required for the CI).
@steindev
Copy link
Member

Also see #7. It is on my list.

@steindev
Copy link
Member

Also see #2815.

@steindev
Copy link
Member

steindev commented May 9, 2022

ThermalTest is gone #4100. But I should add automated analysis scripts to the new Thermal Benchmark #4099 in order to make it a real benchmark.

@PrometheusPi
Copy link
Member

Since the old test is removed and the new test setup is merged and an automatic test is currently developed by @MSVoss, I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: examples PIConGPU or PMacc examples component: tests unit tests
Projects
None yet
Development

No branches or pull requests

3 participants