Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radiation.hpp - Comparision of unsigned & signed types #118

Closed
ax3l opened this issue Dec 6, 2013 · 4 comments
Closed

Radiation.hpp - Comparision of unsigned & signed types #118

ax3l opened this issue Dec 6, 2013 · 4 comments
Assignees
@PrometheusPi
Labels
warning code produces/produced a warning
Milestone
0.2.0: Open Beta

Comments

@ax3l
Copy link
Member

ax3l commented Dec 6, 2013 

src/picongpu/include/plugins/Radiation.hpp:781:14:
  Warnung: Vergleich zwischen vorzeichenbehafteten und vorzeichenlosen
  Ganzzahlausdrücken [-Wsign-compare]

@PrometheusPi See here
@ghost ghost assigned PrometheusPi Dec 6, 2013
@PrometheusPi
Copy link
Member

I will change int to unsigned int.
(Might be, that I will have problems with git.)

@PrometheusPi
Copy link
Member

Checking for warnings on hypnos.

@PrometheusPi
Copy link
Member

Issue solved with:
pull request "Radiation corrections"

@ax3l
Copy link
Member Author

ax3l commented Dec 6, 2013

You can write #119 to link it.

@ax3l ax3l closed this as completed in 0b17a27 Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrometheusPi PrometheusPi

Labels
warning code produces/produced a warning
Projects
None yet
Milestone
0.2.0: Open Beta
Development

No branches or pull requests
2 participants
@ax3l @PrometheusPi