Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBS: Consider an option to fast-path the status endpoint #96

Closed
aimxhaisse opened this issue Aug 22, 2024 · 2 comments · Fixed by #213
Closed

PBS: Consider an option to fast-path the status endpoint #96

aimxhaisse opened this issue Aug 22, 2024 · 2 comments · Fixed by #213

Comments

@aimxhaisse
Copy link
Contributor

aimxhaisse commented Aug 22, 2024

At scale under load, some beacons may wait for the /status call before sending registrations or may simply fallback locally if it takes too much time ; relayers also tend to return errors at tail, this can result in more blocks being unnecessary built locally just because a relayer took more time. Being able to have the PBS status call immediately returns 200 without querying the relayers reduces the time taken in a hot path of beacons, this helps with attestations/block proposals.

I see two downsides:

  • logs can be noisy: if all relayers are down, commit-boost PBS will still be called, will try to reach out to relayers, before returning an error back to the beacon, which will fallback locally,
  • if a relayer is badly configured, it may take time to realize it, for this commit-boost could actually check them once at startup, without blocking the hot-path.
@aimxhaisse
Copy link
Contributor Author

Happy to take this one as well, unsure when I'll have time, ping me if you plan to do it so I remove it from my plate :)

@ltitanb
Copy link
Collaborator

ltitanb commented Aug 22, 2024

We do have something like this which is set using this flag

# Whether to forward `status` calls to relays or skip and return 200
# OPTIONAL, DEFAULT: true
relay_check = true

adding a check at startup would add a nice safety check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants