Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up ssz types #36

Closed
ltitanb opened this issue Jul 24, 2024 · 1 comment · Fixed by #133
Closed

Tidy up ssz types #36

ltitanb opened this issue Jul 24, 2024 · 1 comment · Fixed by #133
Labels
good first issue Good for newcomers pbs Pbs module / Builder API

Comments

@ltitanb
Copy link
Collaborator

ltitanb commented Jul 24, 2024

We're currently using the tree_hash crate, and some hacky workaround since the crate doesn't support alloy yet, eg:

commit-boost-client/crates/pbs/src/types/execution_payload.rs

Lines 85 to 86 in cadefca

#[serde(with = "as_dec_str")]
base_fee_per_gas: EU256,

We should remove the workarounds once this PR is merged
@ltitanb ltitanb added good first issue Good for newcomers pbs Pbs module / Builder API labels Jul 24, 2024
@David-Petrov
Copy link
Collaborator

The referred PR was merged today, so this issue is ready to pick up.

@David-Petrov David-Petrov mentioned this issue Aug 27, 2024
Merged
4 tasks
@ltitanb ltitanb mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pbs Pbs module / Builder API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update eth deps Commit-Boost/commit-boost-client
2 participants
@David-Petrov @ltitanb