Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing logger should use config directory or fallback to default #237

Closed
0ex-d opened this issue Jan 15, 2025 · 0 comments · Fixed by #239
Closed

Tracing logger should use config directory or fallback to default #237

0ex-d opened this issue Jan 15, 2025 · 0 comments · Fixed by #239

Comments

@0ex-d
Copy link
Contributor

0ex-d commented Jan 15, 2025

commit-boost-client/crates/common/src/utils.rs

Lines 184 to 187 in 5749410

let file_appender = builder
.rotation(Rotation::DAILY)
.build(LOGS_DIR_DEFAULT)
.expect("failed building rolling file appender");

The logger should use the provided LogsSettings for extensibility .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Init tracing log should use provided log_dir_path 0ex-d/commit-boost-client
1 participant
@0ex-d