Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit headers size #165

Open
ltitanb opened this issue Oct 23, 2024 · 2 comments
Open

limit headers size #165

ltitanb opened this issue Oct 23, 2024 · 2 comments
Labels
pbs Pbs module / Builder API

Comments

@ltitanb
Copy link
Collaborator

ltitanb commented Oct 23, 2024

The PBS server is assumed to be trusted and accessible only by the beacon node but we could still add a limit on the headers size

mev boost for reference
https://github.com/flashbots/mev-boost/blob/develop/server/service.go#L187

@ltitanb ltitanb added the pbs Pbs module / Builder API label Oct 23, 2024
@0xvv
Copy link

0xvv commented Dec 17, 2024

Looking into this but I think axum does not give access to hyper's configuration for the server so this would require rewriting the PbsService.run() without axum
I'm trying to find a light refactoring to accomplish this as this does not necessarily seem worth a big code change

@ltitanb
Copy link
Collaborator Author

ltitanb commented Dec 17, 2024

agreed, definitely not worth massive changes considering that the beacon node is assumed to be trusted by the sidecar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pbs Pbs module / Builder API
Projects
None yet
Development

No branches or pull requests

2 participants