Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud - Double encoding of URLs #2462

Closed
Lithimlin opened this issue May 25, 2021 · 1 comment
Closed

Nextcloud - Double encoding of URLs #2462

Lithimlin opened this issue May 25, 2021 · 1 comment
Labels
bug Something isn't working unconfirmed

Comments

@Lithimlin
Copy link

Describe the bug
When attempting to open a file of which the name contains a space (e.g. "cool beans.pdf"), the space will be encoded incorrectly and the file declared as missing.

This seems to be caused by a PDF.js module which is probably used in the PDF previewer

To Reproduce
Steps to reproduce the behavior:

  1. Upload a file (e.g. PDF) with a name containing a space (e.g. "cool beans.pdf")
  2. Attempt to open the file to receive a preview in nextcloud
  3. Be greeted with an error that the file is missing

Expected behavior
The file's URL is encoded only once.
Example:
cool beans.pdf -> https://my-cloud.com/remote.php/dav/files/user/cool%20beans.pdf

Actual behavior
The file's URL is encoded twice.
Example:
cool beans.pdf -> https://my-cloud.com/remote.php/dav/files/user/cool%2520beans.pdf

Screenshots
image

Error message

PDF.js v2.5.207 (build: 0974d6052)
Message: Missing PDF "https://cloud-dev.emergencity.de/remote.php/dav/files/jeuler/Inter%2520test.pdf".

Desktop (please complete the following information)

  • OS: ArchLinux
  • Browser: Firefox
  • Version: 88.0.1
@Lithimlin Lithimlin added bug Something isn't working unconfirmed labels May 25, 2021
@Lithimlin
Copy link
Author

It seems this is a nexcloud bug, not a collabora one. My bad
nextcloud/files_pdfviewer#381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed
Projects
None yet
Development

No branches or pull requests

1 participant