Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuncProxy methods incorrectly override parent class methods #41

Closed
duncancumming opened this issue Oct 15, 2014 · 1 comment
Closed
Labels

Comments

@duncancumming
Copy link

In FuncProxy, the functions verifyInvoked, verifyInvokedOnce, verifyNeverInvoked and verifyInvokedMultipleTimes all call the parent functions of the same name in Verifier.

These functions have different definitions than the parent functions they are extending, e.g. FuncProxy->verifyInvoked has arguments $params = null. But Verifier->verifyInvoked has arguments $name, $params = null

Isn't this a violation of E_STRICT error standard? I get this error trying to use test::func()

PHPUnit_Framework_Error_Notice : Declaration of AspectMock\Proxy\FuncProxy::verifyInvoked() should be compatible with AspectMock\Proxy\Verifier::verifyInvoked($name, $params = NULL)

@DavertMik
Copy link
Member

Yeah, you are right. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants