Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@charteafrica Fix SEO failing on production #895

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

koechkevin
Copy link
Contributor

Description

The current charterafrica prod has SEO disabled because none of the stages in charterAFRICA Dockerfile (deps, build, runner) references the NEXT_PUBLIC_SEO_DISABLED ARG. This PR adds a reference for this in the charterfrica build step.

This fix PR has been tested in this build.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin requested a review from a team September 18, 2024 15:00
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-895 Visit

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kilemensi kilemensi added the bug Something isn't working label Sep 18, 2024
@koechkevin koechkevin added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit fea32c0 Sep 18, 2024
6 checks passed
@koechkevin koechkevin deleted the fix-prod-buils branch September 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants