Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openModal is not a function error when adding a link in the RichText Slate editor #1027

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

m453h
Copy link
Contributor

@m453h m453h commented Jan 15, 2025

Description

This PR addresses an issue in the RichText editor for applications using Payload CMS, where attempting to add a link causes the modal with the link input fields to throw an error, as shown below:

Screenshot 2025-01-15 at 10 45 29

To fix this we have pinned the version of payload to 2.30.0 as suggested here

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2025-01-15 at 11 21 50

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@m453h m453h added the bug Something isn't working label Jan 15, 2025
@m453h m453h self-assigned this Jan 15, 2025
@m453h m453h requested a review from a team January 15, 2025 08:24
@kilemensi
Copy link
Member

👍🏽 @m453h

To fix this we have pinned the version of payload to 2.30.0 ...

Not sure I fully understand; does this mean 2.31.0, 2.32.0, etc. won't work as well?

@m453h
Copy link
Contributor Author

m453h commented Jan 15, 2025

👍🏽 @m453h

To fix this we have pinned the version of payload to 2.30.0 ...

Not sure I fully understand; does this mean 2.31.0, 2.32.0, etc. won't work as well?

Yes, I have tested with both 2.31.0 and 2.32.0 and they don't work as well

@kilemensi
Copy link
Member

Yes, I have tested with both 2.31.0 and 2.32.0 and they don't work as well

That's extremely sad @m453h. Cool, if this is not a problem in Payload 3.x then all good, lets deploy this fix and move on as we'll upgrade to 3.x soon.

@m453h m453h added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 8c57d15 Jan 16, 2025
4 checks passed
@m453h m453h deleted the fix/civicsignalblog-fix-text-editor branch January 16, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants