Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-install hook for Plugins #3409

Closed
orta opened this issue Apr 16, 2015 · 2 comments · Fixed by #3540
Closed

Add pre-install hook for Plugins #3409

orta opened this issue Apr 16, 2015 · 2 comments · Fixed by #3540
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.
Milestone

Comments

@orta
Copy link
Member

orta commented Apr 16, 2015

There are at least two CocoaPods plugins that are hacking into CocoaPods in order to provide pre-install setup integration. Both of which want to make runtime changes to the available pods, and the current way the do this removes the need for the plugin to be defined in the Podfile.

Adding support for another plugin hook at the before the install function should offer an opportunity to remove some of these hacks and to encourage bigger-picture plugins for cocoapods.

@orta orta added t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future. d1:easy An easy ticket that is a good start for first-time contributors s1:awaiting input Waiting for input from the original author labels Apr 16, 2015
@segiddins
Copy link
Member

What information would these plugins need ?

@orta
Copy link
Member Author

orta commented Apr 16, 2015

I think it would want access to the current Podfile representation, Pod::Config.instance.podfile and it's own settings dictionary.

@segiddins segiddins added s2:confirmed Issues that have been confirmed by a CocoaPods contributor and removed s1:awaiting input Waiting for input from the original author labels May 30, 2015
@segiddins segiddins added this to the 0.38 milestone May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants